Implement restart policy support in Docker provider.

[tomwilkie]

Fixes #2417

[jen20]

This LGTM, however it also conflicts with #3761. IMO we should merge #3761, and then resolve the merge conflict with the functionality here with regards to failure counts.

[tomwilkie]

I'll rebase/merge tomorrow if that okay? Got to prepare slides today.

[jen20]

Hi @tomwilkie - I'm actually doing it as we speak - you'll still get credit for the commit however!

[jen20]

Hi @tomwilkie, in merging this I realised it had already been applied as part of #3761 in a slightly different form - the restart and max_retry_count are separate arguments. I think this is ok, and perhaps a slight improvement over special string formatting, so for now I'm going to close this PR. If you think there are reasons to prefer this approach over the one in #3761, please reopen and let us know! Many thanks for your contribution - sorry it has taken us so long to get to.

[tomwilkie]

No worries, sounds good.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.