provider/aws Implement username updates properly for aws-sdk-go

[pgray]

This should solve #2818

[catsby]

Does this also fix #2761 ?

[catsby]

Any thoughts on that, @graycoder ?

[pgray]

@catsby the 2 PRs ( This one and #3237 ) related to this that I have open solve #2761 for groups and users, but do not solve it for roles unfortunately. The AWS api doesn't seem to provide the same hooks to update roles... so I haven't found a fix that would close #2761

[catsby]

@graycoder hey sorry for the delay here. Do you by chance have a config that demonstrates for me what this is fixing? I believe that it's good and necessary, but I'm not following when this situation pops up

[pgray]

@catsby This situation pops up when you rename a user.
This is because the API requires that you specifically call the Update functions on users that are in groups instead of just deleting and recreating the user, which is what the current code does.

Without proper update support, one must manually remove the user from any groups they're in when they want to change the user's name (this often happens unexpectedly during an apply). One must also remove any managed policies attached to the user otherwise the same set of events (api errors) happen.

[catsby]

Ah, got it. Thanks @graycoder , this looks good to me!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.