Backport of command/meta_backend: Allow the remote backend to have no workspaces [again] into v1.1 #30165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamterraform
force-pushed
the
backport/chrisarcand/remote-backend-no-workspaces-regression/firmly-beloved-joey
branch
from
fbab62b to
b372ebb
Compare
chrisarcand
deleted the
backport/chrisarcand/remote-backend-no-workspaces-regression/firmly-beloved-joey
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #30142 to be assessed for backporting due to the inclusion of the label 1.1-backport.
The below text is copied from the body of the original PR.
Closes #30129
A regression introduced in d72a413 (#29945)
The comment explains, but TLDR: The remote backend actually depended on being able to write it's backend state even though an 'error' occurred (no workspaces). This is expected behavior for the remote backend:
With the improvements made in the changes mentioned above, an error now means that the backend config should not be written to disk......except in this particular situation, sadly.
There are no tests for this, I know; we don't really have any sort of test harness for initializing this backend (all backend tests like this just use the local backend).