Update create_before_destroy in state during refresh

[jbardin]

While create_before_destroy is stored in the instance state, the status would only be updated when a change to the resource was applied. This meant that if a resource was incorrectly created with the wrong option, it would require a change to the resource itself to fix, which may not be possible with all resources.

This change updates the stored create_before_destroy value while the resource is being refreshed.

Fixes #25473

[codecov]

Codecov Report

Merging #26343 into master will decrease coverage by 0.00%.
The diff coverage is 62.50%.

Impacted Files	Coverage Δ
terraform/node_resource_plan_instance.go	97.64% <ø> (ø)
terraform/eval_state.go	59.89% <62.50%> (+0.11%)	⬆️
terraform/node_resource_plan.go	92.66% <0.00%> (-1.84%)	⬇️
dag/marshal.go	54.79% <0.00%> (+1.36%)	⬆️

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.