Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform vSphere Snapshot management resources by GSLab #14660

Closed
wants to merge 8 commits into from

Conversation

idmsubs
Copy link

@idmsubs idmsubs commented May 19, 2017

Please review code changes implemented for vSphere snapshot management resources.

Resources implemented are :
a. Snapshot management (Create and delete snapshot)
b. Revert snapshot

Referred https://github.com/hashicorp/terraform/blob/master/.github/CONTRIBUTING.md for following standards for Terraform provider.

Please suggest changes if required any.

@idmsubs
Copy link
Author

idmsubs commented May 22, 2017

Travis CI build failing due to issue - #14232

@Freyert
Copy link

Freyert commented Jul 1, 2017

@idmsubs the built in providers have been moved out of master. You will need to remake these changes over on https://github.com/terraform-providers/terraform-provider-vsphere

@idmsubs
Copy link
Author

idmsubs commented Jul 20, 2017

With recent Terraform release and new provider changes, require to create new PR with individual provider repo. Closing this PR.

@idmsubs idmsubs closed this Jul 20, 2017
@grubernaut
Copy link
Contributor

Thanks @idmsubs, and apologies for the extra work required here!

@idmsubs
Copy link
Author

idmsubs commented Jul 27, 2017

Opened hashicorp/terraform-provider-vsphere#107 with new changes for provider.

@grubernaut no problem

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants