provider/aws: Raise timeout for attaching/detaching VPN GW

[radeksimko]

Apparently raising it to 5mins wasn't sufficient as we keep seeing failures like this:

=== RUN   TestAccAWSRouteTable_vgwRoutePropagation
--- FAIL: TestAccAWSRouteTable_vgwRoutePropagation (702.17s)
    testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_vpn_gateway.foo: 1 error(s) occurred:
        
        * aws_vpn_gateway.foo: Error waiting for VPN gateway (vgw-a0c71cbe) to attach: timeout while waiting for state to become 'attached' (last state: 'detached', timeout: 5m0s)
FAIL

[stack72]

This LGTM but this is a candidate to change to the new Timeout structure going forward :)

[radeksimko]

I see your point, but I think that all of our resources should have high enough default timeouts that make all acceptance tests pass regularly. I see the Timeout feature as a solution for resources which may take significantly more time to create/update/delete under certain "non-conventional" conditions (like enormous number of resources and/or enormously big instance types).

In other words I'd like all users to be able to use all resources without having to specify timeouts if their use cases are conventional. Hopefully not many people need to create enormous number of VPN Gateways 😄

[stack72]

agreed :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.