-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_ami_ids
and aws_ebs_snapshot_ids
resources
#13844
Conversation
One thing that I wasn't sure of is whether the data "aws_ebs_snapshot_ids" "test" {
# filter { ... }
}
resource "aws_ebs_volume" "test" {
availability_zone = "us-west-2a"
size = 40
snapshot_id = "${data.aws_ebs_snapshot_ids.test.ids[0]}"
} |
|
One other issue is that there is a fair bit of code duplication between the existing |
Fixes #12081. Adds new `aws_ami_ids` and `aws_ebs_snapshot_ids` resources.
This LGTM! Thanks for this @joshuaspence :) I am presuming those now closes #12081 ?
|
Thanks very much for this @joshuaspence indeed! |
As a follow up to #13844, this pull request sorts the AMIs and snapshots returned from the aws_ami_ids and aws_ebs_snapshot_ids data sources, respectively.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #12081. Adds new
aws_ami_ids
andaws_ebs_snapshot_ids
resources.