Add initial Direct Connect resources

[bodgit]

This is based in part on the work started in #5212 however I've just adapted the single resource I need:

• aws_directconnect_public_virtual_interface_confirm

I've updated it with the missing attributes and import functionality and also renamed the resource slightly so it fits better with the naming convention of other resources, (IMHO!).

Sadly this has the same sticking point in that testing it the same way as most other AWS resources doesn't really work as a) it involves more than one AWS account and b) Direct Connect infrastructure quite often involves some manual operator involvement or can take some time to be verified by AWS staff.

The directconnectiface package gives the ability to mock the API so I could test the Terraform resource without having to create anything physical/virtual however I'm struggling to work out how I can slot it in to the testing framework, it looks like I need to make my own AWSClient with a mocked dcconn.

I can't see any existing resources that I can copy or use for inspiration so I'm asking for some guidance here. I'd really like to get this resource added as it's the last outstanding piece I have left and maybe once the tests are figured out it'll help with adding the remaining Direct Connect resources.

[akumria]

[bikeshed]: It really would be nice if the resource was named 'aws_dx_...'

Comparing the two PRs, I generally prefer PR#5212 since cover both the public and private virtual interface confirmation.

[bodgit]

I'll close this in preference to hashicorp/terraform-provider-aws#876.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.