-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allow_empty
attribute to aws_ami
and aws_ebs_snapshot
data sources
#12231
Conversation
@@ -228,7 +234,13 @@ func dataSourceAwsAmiRead(d *schema.ResourceData, meta interface{}) error { | |||
|
|||
var image *ec2.Image | |||
if len(filteredImages) < 1 { | |||
return fmt.Errorf("Your query returned no results. Please change your search criteria and try again.") | |||
if d.Get("allow_empty").(bool) { | |||
d.SetId("-") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really really sure if this is necessary or if there is a better null
value.
|
|
Actually, let me open a new pull request given that I've changed the implementation a fair bit. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #12081.