Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws Add support for WAF Regional #11263

Closed
wants to merge 3 commits into from

Conversation

neildothunter
Copy link

This is a straight copy of the current Terraform WAF resources (tests and docs) amended to use the WAF Regional API (the resulting WAF resources can then be associated with an Application Load Balancer in that region). As such it contains the same bugs as the current WAF resources.

WAF Regional endpoints (http://docs.aws.amazon.com/general/latest/gr/rande.html#waf_region ) are only available in us-east-1, us-west-2, eu-west-1 and ap-northeast-1. There is nothing here to provide early warning that the region may not support wafregional.

Use aws_wafregional_* resources in addition to aws_waf_* follows the pattern set by the API, but doesn't feel "completely right".

@neildothunter
Copy link
Author

looks like my branch is out of step. Is this something i need to fix?

@neildothunter
Copy link
Author

aws_wafregional_web_acl_association facilitates link between WAF Regional WebACL and ALB. Fixes #10713.

@neildothunter neildothunter changed the title [WIP] provider/aws Add support for WAF Regional provider/aws Add support for WAF Regional Jan 20, 2017
@Abrishges
Copy link

How can I associate my alb with WAF ACL?

resource "aws_wafregional_web_acl_association" "waf_alb_regional" { ............ }

@neildothunter
Copy link
Author

That resource takes a webacl and alb id. The resource documentation is with the PR (https://github.com/neildothunter/terraform/blob/6e81561bde53e8e78baa767ff61b706bde138ab0/website/source/docs/providers/aws/r/wafregional_web_acl_association.html.markdown ). However this PR is getting a little old.

@Abrishges
Copy link

@neildothunter : thank you! I think the provider is not supported by terraform yet. I getting the following error.

Errors:

  • aws_wafregional_web_acl_association.wafassociation: Provider doesn't support resource: aws_wafregional_web_acl_association

@neildothunter
Copy link
Author

This is a Pull Request (a request for this code to be merged into the main Terraform branch at which point it can be cut for a release). It will be closed once/if merged.

Until that point you could for example use the local-exec provisioner to call AWS CLI command http://docs.aws.amazon.com/cli/latest/reference/waf-regional/associate-web-acl.html or a Cloudformation stack or which ever method you use to create resources not supported by Terraform.

@gjobin
Copy link

gjobin commented Mar 28, 2017

I'm not sure, but I think you must resolve the conflicts before it can be merged.
Nice addition by the way.

This was referenced Apr 15, 2017
@radeksimko radeksimko added the waiting-response An issue/pull request is waiting for a response from the community label Apr 16, 2017
@neildothunter
Copy link
Author

Sure. There will be other opportunities to make the contributor list ;)

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants