Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: aws_elasticache_replication_group_id validation change #8381

Merged
merged 1 commit into from
Aug 23, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Aug 22, 2016

Fixes #8379

The AWS documentation tells us the following:

--replication-group-id (string)

The replication group identifier. This parameter is stored as a
lowercase string.
Constraints:
A name must contain from *1 to 20* alphanumeric characters or hyphens.
The first character must be a letter.
A name cannot end with a hyphen or contain two consecutive hyphens.

This is not correct and is causing users errors:

* aws_elasticache_replication_group.bar: Error creating Elasticache
* Replication Group: InvalidParameterValue: Replication group id should
* be no more than 16 characters.
    status code: 400, request id:

Tuning the Validation from 20 to 16 characters to avoid user issues

The AWS documentation tells us the following:

```
--replication-group-id (string)

The replication group identifier. This parameter is stored as a
lowercase string.
Constraints:
A name must contain from *1 to 20* alphanumeric characters or hyphens.
The first character must be a letter.
A name cannot end with a hyphen or contain two consecutive hyphens.
```

This is not correct and is causing users errors:

```
* aws_elasticache_replication_group.bar: Error creating Elasticache
* Replication Group: InvalidParameterValue: Replication group id should
* be no more than 16 characters.
    status code: 400, request id:
```

Tuning the Validation from 20 to 16 characters to avoid user issues
@jen20
Copy link
Contributor

jen20 commented Aug 23, 2016

LGTM

@stack72 stack72 merged commit 780ef8b into master Aug 23, 2016
@stack72 stack72 deleted the aws-elasticache-rg-primary-endpoint branch August 23, 2016 10:05
@devinsba
Copy link

Is there a way to report bugs back to the AWS folks on this for their docs?

c4milo added a commit to hooklift/terraform that referenced this pull request Aug 23, 2016
* master: (100 commits)
  Update CHANGELOG.md
  providers/aws: Check error from resourceAwsRoute53RecordBuildSet and return err if set (hashicorp#8399)
  Update CHANGELOG.md
  provider/aws: Add support for ECS svc - LB target group (hashicorp#8190)
  Added example of how the Option settings works (hashicorp#8413)
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  provider/aws: Add support for `network_mode` to `aws_ecs_task_definition` (hashicorp#8391)
  Update CHANGELOG.md
  Update CHANGELOG.md
  provider/aws: Add Primary Endpoint Address output for (hashicorp#8385)
  Update CHANGELOG.md
  provider/aws: `aws_elasticache_replication_group_id` validation change (hashicorp#8381)
  provider/google: Remove redundant type declaration
  provider/google: Hook in state migration function
  provider/openstack: docs and tests for allowed_address_pairs
  Update CHANGELOG.md
  website: Docs for AWS API Gateway domain name and base path mapping
  provider/aws: aws_api_gateway_base_path_mapping resource implementation
  ...
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticache Replication Group allows replication_group_id to be longer than aws will accept
3 participants