-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/azurerm: Add azurerm_virtual_machine_scale_set
resource
#6711
Conversation
stack72
commented
May 17, 2016
•
edited
Loading
edited
- Schema
- CRUD
- Acceptance Tests
- Documentation
b160379
to
2d9e677
Compare
90ad0ba
to
38d3c83
Compare
e0cb175
to
9c91ff6
Compare
azurerm_virtual_machine_scale_set
resourceazurerm_virtual_machine_scale_set
resource
m := v.(map[string]interface{}) | ||
buf.WriteString(fmt.Sprintf("%s-", m["name"].(string))) | ||
//buf.WriteString(fmt.Sprintf("%v-", m["caching"].(string))) | ||
//buf.WriteString(fmt.Sprintf("%v-", m["create_option"].(string))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented bits here. Not sure if they need to be in or are a TODO?
efb172e
to
4b1f9f8
Compare
Looking great overall! Some in line Qs for you above, and one overall question on attr naming -> I see that a lot of the blocks are I think once we get the deep-nested attributes bugs sorted we'll move everything over to that, but in the meantime just a thought that might make the "flattened workaround" style config a big cleaner. |
4b1f9f8
to
03ad41a
Compare
03ad41a
to
5f4c2c3
Compare
LGTM with edits! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |