Update broken in AWS Inspector Resource Group (trivial, with fix)

[jtsaito]

Terraform Version

v0.9.0-beta1 (and previous versions)

Affected Resource(s)

• aws_inspector_resource_group
• aws_inspector_assessment_target

Important note

Please read the section entitled Important Factoids first!

Terraform Configuration Files

Error occurred on updating the tags in the aws_inspector_resource_group.

resource "aws_inspector_resource_group" "inspector" {
  tags {
    "babbel:name" = "bookshelf-other"
  }
}

resource "aws_inspector_assessment_target" "inspector" {
  name               = "foo"
  resource_group_arn = "${aws_inspector_resource_group.inspector.arn}"
}

Debug Output

https://gist.github.com/jtsaito/0b880647f6a53a37a7d5f7748e88c96d (slightly modified)

Panic Output

None. Please see fix below instead.

Expected Behavior

The resource should be updated without terminating with an error and the attribute tag should be set too `"babbel:name" = "bookshelf-other" in the JSON.

Actual Behavior

Fails to update with error message.

* aws_inspector_assessment_target.inspector: InvalidParameter: 1 validation error(s) found.
- missing required field, UpdateAssessmentTargetInput.ResourceGroupArn.

Steps to Reproduce

Trivial.
(1) Create aws_inspector_resource_group and resource_group_arn resources pointing to the first.
(2) Change the tags attribute in the aws_inspector_resource_group and apply again.

Important Factoids

The bug is obvious in the terraform source for resourceAwsInspectorAssessmentTargetUpdate :

terraform/builtin/providers/aws/resource_aws_inspector_assessment_target.go

Line 99 in 4e96da5

input.AssessmentTargetName = aws.String(n.(string))

if d.HasChange("resource_group_arn") {
	_, n := d.GetChange("resource_group_arn")
	input.AssessmentTargetName = aws.String(n.(string))
}

The function call is updating the wrong attribute:AssessmentTargetName instead of AssessmentTargetArn. The fix should trivial and as follows.

if d.HasChange("resource_group_arn") {
	_, n := d.GetChange("resource_group_arn")
	input.AssessmentTargetArn = aws.String(n.(string))
}

References

The required AssessmentTargetArnis not updated because the AssessmentTargetName is overwritten instead by mistake, c.f.: AWS Go SDK.

[stack72]

Hi @jtsaito

Thanks for raising the issue here - also, thanks for investigating the cause :) PR being tested to fix this right now

Thanks

Paul

[jtsaito]

@stack72 Great, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.