Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate provider to tf plugin sdk #982

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Migrate provider to tf plugin sdk #982

merged 2 commits into from
Mar 2, 2020

Conversation

koikonom
Copy link
Contributor

@koikonom koikonom commented Mar 2, 2020

No description provided.

@koikonom koikonom requested a review from a team March 2, 2020 18:40
@ghost ghost added the size/xxl Relative Sizing: Extra-Extra-Large label Mar 2, 2020
bill-rich
bill-rich approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koikonom koikonom merged commit 9c822cc into master Mar 2, 2020
@koikonom koikonom deleted the sdk branch March 2, 2020 19:21
@koikonom koikonom mentioned this pull request Mar 2, 2020
Closed
@LorbusChris
Copy link

LorbusChris commented Mar 2, 2020 •
edited
Loading

Looks like this PR broke provider_test.go. Over in #948 I had updated the providers used in the test to make them pass.

@LorbusChris
Copy link

@koikonom @aareet @bill-rich

@koikonom
Copy link
Contributor Author

koikonom commented Mar 2, 2020

I'm on it, thanks for noticing!

@koikonom
Copy link
Contributor Author

koikonom commented Mar 2, 2020

Created #984 . Sorry for that :)

@LorbusChris
Copy link

That was quick =) Awesome, thanks!

@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aareet aareet aareet approved these changes

@bill-rich bill-rich bill-rich approved these changes

Assignees
No one assigned
Labels
size/xxl Relative Sizing: Extra-Extra-Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koikonom @LorbusChris @aareet @bill-rich