Do not throw error when disk path is not known yet #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the path to an attached disk is interpolated, then sometimes we may end up in a situation where the diff for the VM having the disks runs before the disk itself has been processed. In this case since the path has no value we throw an error. This changes the behaviour so we check if the path has been calculated before we consider it final or not.
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the path to an attached disk is interpolated, then sometimes we may
end up in a situation where the diff for the VM having the disks runs
before the disk itself has been processed. In this case since the path
has no value we throw an error.
This changes the behaviour so we check if the path has been calculated
before we consider it final or not.