Mark windows_sysprep_text as sensitive #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey @bill-rich, just curious if there were any concerns in getting this merged before the next release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a sysprep file it is fairly common to include passwords as part of the setup. Our particular use case is during the domain joining step, though specifying an administrator password is another common case. It seems that Microsoft's official guidance on "hiding" this sensitive data is simply base64 encoding it which obviously is not truly protecting this information. The PR simply marks the field as sensitive so that any passwords in the file will not be revealed during the plan phase.