Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: d/vsphere_network add support for network_type #2281

Merged
merged 1 commit into from
Oct 16, 2024
Merged

feat: d/vsphere_network add support for network_type #2281

merged 1 commit into from
Oct 16, 2024

Conversation

burnsjared0415
Copy link
Collaborator

@burnsjared0415 burnsjared0415 commented Oct 10, 2024 •
edited
Loading

Description

Added the feature to allow for port group to be found if there are two port groups with the same name but one is standard virtual port group vs distributed virtual port group.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccDataSourceVSphereNetwork_hostPortgroups$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok github.com/hashicorp/terraform-provider-vsphere/vsphere 0.847s

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Closes #1143
Closes #1410

@burnsjared0415 burnsjared0415 added this to the v2.10.0 milestone Oct 10, 2024
@burnsjared0415 burnsjared0415 self-assigned this Oct 10, 2024
@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider needs-review Status: Pull Request Needs Review labels Oct 10, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat/d/vsphere_netowrk-add-supprot-for-port-group-type branch from 2c01073 to 6046f0b Compare October 10, 2024 15:33
@burnsjared0415 burnsjared0415 added the enhancement Type: Enhancement label Oct 10, 2024
@burnsjared0415 burnsjared0415 mentioned this pull request Oct 10, 2024
Closed
tenthirtyam
tenthirtyam requested changes Oct 10, 2024
View reviewed changes
vsphere/internal/helper/network/network_helper.go Outdated Show resolved Hide resolved
vsphere/internal/helper/network/network_helper.go Outdated Show resolved Hide resolved
website/docs/d/network.html.markdown Outdated Show resolved Hide resolved
website/docs/d/network.html.markdown Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
vsphere/data_source_vsphere_network.go Outdated Show resolved Hide resolved
website/docs/d/network.html.markdown Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam marked this pull request as ready for review October 10, 2024 16:40
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 10, 2024 16:40
@burnsjared0415 burnsjared0415 force-pushed the feat/d/vsphere_netowrk-add-supprot-for-port-group-type branch from 6046f0b to 1616769 Compare October 10, 2024 16:55
@burnsjared0415 burnsjared0415 force-pushed the feat/d/vsphere_netowrk-add-supprot-for-port-group-type branch 2 times, most recently from cfd7226 to 65de73e Compare October 10, 2024 19:36
tenthirtyam
tenthirtyam requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor recomendations.

@burnsjared0415 burnsjared0415 force-pushed the feat/d/vsphere_netowrk-add-supprot-for-port-group-type branch from 65de73e to 011f923 Compare October 10, 2024 20:44
@burnsjared0415
feat: d/vsphere_network add support for network_type
539d271 
Added the feature to allow for port group to be found if there are two port groups with the same name but one is standard virtual port group vs distributed virtual port group.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@burnsjared0415 burnsjared0415 force-pushed the feat/d/vsphere_netowrk-add-supprot-for-port-group-type branch from 011f923 to 539d271 Compare October 11, 2024 13:55
tenthirtyam
tenthirtyam approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

vsphere/data_source_vsphere_network.go Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Oct 11, 2024
@tenthirtyam tenthirtyam merged commit 87d853e into hashicorp:main Oct 16, 2024
5 checks passed
@github-actions GitHub Actions
Copy link

This functionality has been released in v2.10.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iBrandyJackson iBrandyJackson iBrandyJackson approved these changes

@tenthirtyam tenthirtyam tenthirtyam approved these changes

@spacegospod spacegospod Awaiting requested review from spacegospod

@appilon appilon Awaiting requested review from appilon

Assignees

@burnsjared0415 burnsjared0415

Labels
documentation Type: Documentation enhancement Type: Enhancement provider Type: Provider
Projects
None yet
Milestone
v2.10.0
3 participants
@burnsjared0415 @tenthirtyam @iBrandyJackson