Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert type change of vsan_disk_group #1615

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Revert type change of vsan_disk_group #1615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
684f9e4
Revert type change
appilon Mar 8, 2022
08b0c4e
Update CHANGELOG.md
appilon Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
## 2.2.0 (Unreleased)
## 2.1.1 (Unreleased)

**If you are using v2.1.0, please upgrade to this new version as soon as possible.**

BUG FIXES:
* `resource/compute_cluster`: Revert [GH-1432] switching `vsan_disk_group` back to `TypeList`. Switching from `TypeList` to `TypeSet` is a sore spot when it comes to what is considered a breaking change to provider configuration. Generally we accept that users may use list indices within their config. When this attribute switched to `TypeSet` this caused a breaking change for configurations doing that, as `TypeSet` is indexed by a hash value that Terraform calculates. Furthermore other code around type assertions was not changed and this attribute actually crashed the provider in `v2.1.0`, we will address the now re-opened [GH-1205] in `v3.0.0` of the provider. [GH-1615]

FEATURES:
* `resource/virtual_machine`: Adds support to check the power state of the resource. ([#1407](https://github.com/terraform-providers/terraform-provider-vsphere/issues/1407))
Expand Down
2 changes: 1 addition & 1 deletion vsphere/resource_vsphere_compute_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ func resourceVSphereComputeCluster() *schema.Resource {
Description: "Whether the VSAN service is enabled for the cluster.",
},
"vsan_disk_group": {
Type: schema.TypeSet,
Type: schema.TypeList,
Optional: true,
Computed: true,
Description: "A list of disk UUIDs to add to the vSAN cluster.",
Expand Down