Acceptance test simplification and related changes #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 8, 2021 11:09
Some minor changes to the lab TF code to make it more configurable.
Also simplify tests.
Also simplify tests.
appilon
approved these changes
Apr 8, 2021
| @@ -137,10 +179,21 @@ resource "local_file" "vcsa_template" { | |||
| }) | |||
| filename = "./tmp/vcsa.json" | |||
| provisioner "local-exec" { | |||
| command = "sleep 290; echo five more; sleep 290; TERM=xterm-256color ./tmp/mnt/vcsa-cli-installer/lin64/vcsa-deploy install --accept-eula --acknowledge-ceip --no-ssl-certificate-verification --verbose --skip-ovftool-verification ./tmp/vcsa.json" | |||
| command = "sleep 290; echo five more; sleep 290; TERM=xterm-256color ${var.VCSA_DEPLOY_PATH} install --accept-eula --acknowledge-ceip --no-ssl-certificate-verification --verbose --skip-ovftool-verification $(pwd)/tmp/vcsa.json" | |||
There was a problem hiding this comment.
I recall the sleep 290; echo five more as unnecessary when i set things up... but my memory is hazy
There was a problem hiding this comment.
sometimes the server is not immediately available, which is why this long sleep was added.
Merged
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as an effort to run tests against vsphere 7.0, but ended up fixing a few outstanding bugs and making the acceptance tests a bit simpler by reusing some resources instead of building new ones each time.
There are some outstanding issues with the tests, but these will addressed in separate PRs.