Ignore thin_provisioned and eagerly_scrub during DiskPostCloneOperation

[mtnbikenc]

Description

In some environments the disk provisioning type can change silently when cloning due to vSphere storage policies.  Thin provisioning cannot be managed by Terraform and therefore should not attempt to set these value after cloning.

Error message:

ERROR                                              
ERROR Error: error reconfiguring virtual machine: error processing disk changes post-clone: disk.0: cannot change the value of "thin_provisioned" - (old: false new: true) 
ERROR                                              
ERROR   on ../../../../../tmp/openshift-install-068412821/master/main.tf line 1, in resource "vsphere_virtual_machine" "vm": 
ERROR    1: resource "vsphere_virtual_machine" "vm" { 
ERROR                                              

Attempting to ignore these changes have been unsuccessful using the following:

lifecycle {
    ignore_changes = [
      disk.0.eagerly_scrub,
      disk.0.thin_provisioned,
      ]
  }

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

References

#1028
#1075
#1125

[bill-rich]

This makes sense. Thanks for the contribution!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!