Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding vapp properties while OVF deployment #1082

Merged
merged 2 commits into from
May 31, 2020
Merged

Adding vapp properties while OVF deployment #1082

merged 2 commits into from
May 31, 2020

Conversation

sumitAgrawal007
Copy link
Contributor

@sumitAgrawal007 sumitAgrawal007 commented May 14, 2020 •
edited
Loading

Description

Adding VApp properties when deploying a vm from OVF template

Acceptance tests

References

#1074

@ghost ghost added size/s Relative Sizing: Small documentation Type: Documentation labels May 14, 2020
@sumitAgrawal007 sumitAgrawal007 changed the title Adding vapp properties while OVF deployment WIP Adding vapp properties while OVF deployment May 15, 2020
shylasrinivas
shylasrinivas suggested changes May 15, 2020
View reviewed changes
Copy link

@shylasrinivas shylasrinivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work required based on testing results.

@sumitAgrawal007 sumitAgrawal007 marked this pull request as draft May 17, 2020 06:15
@sumitAgrawal007 sumitAgrawal007 changed the title WIP Adding vapp properties while OVF deployment Adding vapp properties while OVF deployment May 21, 2020
@sumitAgrawal007
Copy link
Contributor Author

@bill-rich Can you please review this PR

@sumitAgrawal007 sumitAgrawal007 marked this pull request as ready for review May 22, 2020 06:26
@sumitAgrawal007 sumitAgrawal007 mentioned this pull request May 22, 2020
Closed
@k3nny0ne
Copy link

Any progress on it?

@sumitAgrawal007
Copy link
Contributor Author

@bill-rich Can you review please

bill-rich
bill-rich approved these changes May 31, 2020
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bill-rich bill-rich merged commit ef72296 into hashicorp:master May 31, 2020
@aareet aareet linked an issue Jun 26, 2020 that may be closed by this pull request
OVF (vApp) Properties are not correctly applied after OVF import #1074
Closed
@ghost
Copy link

ghost commented Jul 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shylasrinivas shylasrinivas shylasrinivas requested changes

@bill-rich bill-rich bill-rich approved these changes

Assignees
No one assigned
Labels
documentation Type: Documentation size/s Relative Sizing: Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OVF (vApp) Properties are not correctly applied after OVF import
4 participants
@sumitAgrawal007 @k3nny0ne @bill-rich @shylasrinivas