add flag for all version deletion

[Lucretius]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #760

Release note for CHANGELOG:

Add `delete_all_versions` flag to `vault_generic_secret` resource to allow Terraform to delete all versions of a kv-v2 secret so that the entire secret is removed from Vault.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[briananstett]

@Lucretius any update on this?

[Lucretius]

@Lucretius any update on this?

I am pretty sure the only test that failed for this was a flaky DB related test unrelated to the added functionality so I think it just needs approval to get merged in.

[briananstett]

@kalafut would it be possible to get this merged for the next release?

[briananstett]

@catsby Any update on this? We really need this feature. We'd really would like to start using Vualt KV v2 but don't want to have oprhaned versions.

[rcreasey]

+1 for this feature

[ejtbrown]

+1 for this; would love to see it in place

[bobthebuilderberlin]

+1, we would also need this.

[benashz]

Moving this work to #1254.

Thank you for your contribution to HashiCorp!