-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support missing token parameters on vault_okta_auth_backend
resource
#2210
Conversation
vault_okta_auth_backend
resource
@@ -262,188 +275,14 @@ resource "vault_okta_auth_backend" "test" { | |||
`, path, organization) | |||
} | |||
|
|||
func testAccOktaAuthBackend_InitialCheck(s *terraform.State) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a legacy style of checking parameters that introduced a panic. Updated to use the newer style of using resource.TestCheckAttr
Default: "0", | ||
ValidateFunc: validateOktaTTL, | ||
StateFunc: normalizeOktaTTL, | ||
Deprecated: "Deprecated. Please use `token_max_ttl` instead.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were previously supported in lieu of the token_ttl
and token_max_ttl
fields. Since we are adding parity for those fields, these can now be deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me! Great job! 👏
I had one question, just to verify - Were these parameters added later on to Okta? Do we need to guard them with a version check, or are these available in most versions?
Good question! Looks like these fields have existed since before Vault 1.10.x and they just hadn't been included in the resource 😬 So we should be good, thanks for confirming 🙏🏼 |
Description
Supports missing common token parameters.
Relates OR Closes #1353
Checklist
Output from acceptance testing: