performance improvements on mount fetch #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
changed the title
fairclothjm
force-pushed
the
VAULT-21523/get-mount
branch
from
23ccd2b to
b478ba2
Compare
fairclothjm
force-pushed
the
get-mount/remaining
branch
from
980462d to
3037b0c
Compare
2 tasks
vinay-gopalan
approved these changes
Feb 22, 2024
fairclothjm
force-pushed
the
VAULT-21523/get-mount
branch
from
b478ba2 to
ae8e2b4
Compare
fairclothjm
force-pushed
the
get-mount/remaining
branch
from
1275990 to
3fcf3cc
Compare
raymonstah
reviewed
Feb 26, 2024
|
|
||
| // If we fell out here then we didn't find our Auth in the list. | ||
| if err := d.Set("type", auth.Type); err != nil { |
There was a problem hiding this comment.
If we want the error checks for d.Set to be ignored, it seems like we can set up an exclusion: https://github.com/golangci/golangci-lint/blob/master/.golangci.reference.yml#L266-L299
There was a problem hiding this comment.
Thanks! I think we should probably enforce error checking in this case just to be safe.
|
Merging to the base branch |
fairclothjm
added a commit
that referenced
this pull request
Feb 26, 2024
* auth/mount: fetch single vault resource on read * fetch api psuedo tag for api wrappers * remove comment * fix failing case where resource needs to be recreated * performance improvements on mount fetch (#2152) * add mountutil and GetMount * fix nomad backend existence check * fix context arg * use GET instead of LIST for auth mount fetching * normalize error response * changelog * fix github auth path * fix auth existence checking * use contexts and add log * fix build and rebase * make golangci-lint happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up to #2145. Here we make similar improvements across the remaining resources that were superfluously calling LIST instead of GET.
Checklist