Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessor computed attribute for gcp auth backend #1980

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Add accessor computed attribute for gcp auth backend #1980

merged 4 commits into from
Aug 17, 2023

Conversation

jdelnano
Copy link
Contributor

@jdelnano jdelnano commented Aug 15, 2023 •
edited
Loading

Description

This PR updates the schema and read functionality for the vault_gcp_auth_backend resource in order to define, set, and expose the accessor attribute.

Closes #1964 since this will expose the accessor attribute for the vault_gcp_auth_backend resource.

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jdelnano jdelnano marked this pull request as ready for review August 15, 2023 20:21
@jdelnano jdelnano force-pushed the jdelnano_add-accessor-to-gcp-auth-backend branch from 7abff14 to bdcca45 Compare August 15, 2023 20:27
@jdelnano jdelnano force-pushed the jdelnano_add-accessor-to-gcp-auth-backend branch from bdcca45 to 29db013 Compare August 15, 2023 20:32
austingebauer
austingebauer approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @jdelnano 👍

austingebauer
austingebauer reviewed Aug 17, 2023
View reviewed changes
austingebauer
austingebauer reviewed Aug 17, 2023
View reviewed changes
@austingebauer austingebauer added this to the 3.20.0 milestone Aug 17, 2023
@austingebauer austingebauer merged commit a9070d1 into hashicorp:main Aug 17, 2023
@jdelnano jdelnano mentioned this pull request Sep 1, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingebauer austingebauer austingebauer approved these changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
3.20.0
Development

Successfully merging this pull request may close these issues.

vault_gcp_auth_backend resource is missing the accessor attribute
3 participants
@jdelnano @hashicorp-cla @austingebauer