Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated function oktaAuthBackendExists #1842

Merged
merged 1 commit into from
May 5, 2023
Merged

remove deprecated function oktaAuthBackendExists #1842

merged 1 commit into from
May 5, 2023

Conversation

jsab
Copy link
Contributor

@jsab jsab commented May 4, 2023 •
edited
Loading

Without this, terraform always tries to create vault_okta_auth_backend resources that use the namespace attribute (and fails because they already exist) because it searches in the provider namespace for auths instead of in the appropriate namespace.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Fixed resource vault_okta_auth_backend not honoring namespace attribute correctly

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@hashicorp-cla
Copy link

hashicorp-cla commented May 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

benashz
benashz reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jsab . Please see my comments about dropping the oktaAuthBackendExists function all together.

vault/resource_okta_auth_backend.go Outdated Show resolved Hide resolved
@jsab jsab force-pushed the fix-okta-auth branch from 9a7fdcf to a810cf3 Compare May 4, 2023 20:46
@jsab jsab changed the title fix okta_auth_backend not honoring namespace remove deprecated function oktaAuthBackendExists May 4, 2023
@jsab jsab requested a review from benashz May 4, 2023 20:49
benashz
benashz approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for contributing to HashiCorp!

@benashz benashz merged commit e55cfcd into hashicorp:main May 5, 2023
@jsab
Copy link
Contributor Author

jsab commented May 9, 2023

@benashz When can we expect the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsab @hashicorp-cla @benashz