Avoid writing empty strings to Vault when creating managed keys #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymonstah
approved these changes
Mar 21, 2023
fairclothjm
approved these changes
Mar 21, 2023
fairclothjm
reviewed
Mar 21, 2023
| @@ -158,6 +158,53 @@ func TestManagedKeys(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| // The following test requires a Vault server to be set up with a specific server configuration | |||
There was a problem hiding this comment.
Are these steps documented somewhere? I am not confident I could get this test running by following this comment alone.
There was a problem hiding this comment.
Good call, I can document the steps to create a PKCS#11 key and share it to our Google Drive folder or Confluence
There was a problem hiding this comment.
Thanks! I made a note to discuss in our dev sync. But I think we should make sure any local only test setups are well documented. I think creating a Confluence page to document these is a good idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fix where empty strings were being written to Vault. We should make it so that only fields provided by the user are written along with the data to Vault; if a field is not provided, empty string values should not be written. This was causing PKCS key creation to fail, since two mutually exclusive fields
slotandtoken_labelwere both being sent to Vault. The PR also adds a test that is meant to be run locally since it requires a lot of prior setup (including its own Vault server config)Fixes #1772
Output from acceptance testing: