Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all transform resources with namespace support #1558

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Update all transform resources with namespace support #1558

merged 3 commits into from
Aug 2, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Aug 2, 2022

All transform resources/data sources should support namespaces. In the
future we will move the related code under the main vault package to
ensure that all global resource updates are applied consistently.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@benashz
Update all transform resources with namespace support
1d11ea2 
All transform resources/data sources should support namespaces. In the
future we will move the related code under the main vault package to
ensure that all global resource updates are applied consistently.
@benashz benashz added the bug label Aug 2, 2022
@benashz benashz added this to the 3.8.1 milestone Aug 2, 2022
@benashz benashz requested a review from vinay-gopalan August 2, 2022 15:18
@vinay-gopalan
Copy link
Contributor

Looks like we also will have to update the transform tests such as TestTransformationName which now receive additional parameters

@benashz benashz merged commit 83b8883 into main Aug 2, 2022
@benashz benashz deleted the VAULT-7389/support-namespaces-in-transform branch August 2, 2022 17:37
@benashz
Copy link
Contributor Author

benashz commented Aug 2, 2022

Looks like we also will have to update the transform tests such as TestTransformationName which now receive additional parameters

Yes indeed. Fixed in 77f5348

marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@benashz
Update all transform resources with namespace support (hashicorp#1558)
d6912ec 
All transform resources/data sources should support namespaces. In the
future we will move the related code under the main vault package to
ensure that all global resource updates are applied consistently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
bug size/XL
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@benashz @vinay-gopalan