Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local tls certificate file as input for tls_certificate data source #139

Closed
wants to merge 4 commits into from

Conversation

dttung2905
Copy link

Hi team,

I would like to propose a new feature to support local tls file as an input for tls_certificate data source.

Example:

For local file

data "tls_certificate" "test" {
   input  =  file("testdata/tls_certs/public.pem")
   type   = "local"

For remote file (sitting behind and HTTPS endpoint)

data "tls_certificate" "test" {
 input = "https://your-target-website.com"
 type  = "remote"

This will serve as an extension for #62 solve #4 where the author wants to read from file ${file('path/to/cert.pem')} for example

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 22, 2021

CLA assistant check
All committers have signed the CLA.

@dttung2905
Copy link
Author

Hi @bflad,
Happy New Year to you !
It seems like you are the only active maintainers of this repo. Could you help review this MR too?

@dttung2905
Copy link
Author

Hi @kmoe and @detro , I see that you both are the only active contributors for this project. May I have your feedback for this MR ?

iwarapter added a commit to iwarapter/terraform-provider-tls that referenced this pull request Apr 25, 2022
iwarapter added a commit to iwarapter/terraform-provider-tls that referenced this pull request Apr 26, 2022
iwarapter added a commit to iwarapter/terraform-provider-tls that referenced this pull request Apr 26, 2022
detro pushed a commit to iwarapter/terraform-provider-tls that referenced this pull request May 5, 2022
@detro detro closed this in #189 May 5, 2022
detro pushed a commit that referenced this pull request May 5, 2022
* Closes #139 support parsing certificate content #4

* Using hash of certificates as ID for 'tls_certificate' data source

* Update CHANGELOG.md

* Adding BUGFIX + NOTES to the CHANGELOG as we are now fixing issue #79.

Co-authored-by: Ivan De Marino <ivan.demarino@hashicorp.com>
jackivanov pushed a commit to jackivanov/terraform-provider-tls that referenced this pull request Aug 4, 2022
* Closes hashicorp#139 support parsing certificate content hashicorp#4

* Using hash of certificates as ID for 'tls_certificate' data source

* Update CHANGELOG.md

* Adding BUGFIX + NOTES to the CHANGELOG as we are now fixing issue hashicorp#79.

Co-authored-by: Ivan De Marino <ivan.demarino@hashicorp.com>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants