This repository has been archived by the owner on Nov 14, 2020. It is now read-only.
grant/default privileges: Fix schema verification. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To check if `postgresql_grant` or `postgresql_default_privileges` resources exists, the provider was first checking if database/schema for which they will be applied exist. For the schema, we created a specific connection on the right database to check it it was mistakenly using the wrong connection and was checking if schema exists on the database defined in provider. (Basically it was working only for schema `public` which exists by default in all databases)
ghost
added
the
|
@cyrilgdn Looks good to me. Travis doesn't pass but the failure is unrelated. |
|
@multani Thanks !
Yes it's a known problem that I need to look at. It randomly fails just for this Postgres version, restarting the build works. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check if
postgresql_grantorpostgresql_default_privilegesresources exist,the provider is first checking if database/schema for which they will be applied exist.
For the schema, we created a specific connection on the right database to check
it but it was mistakenly using the wrong connection and was checking if schema exists
on the database defined in provider.
(Basically it was working only for schema
publicwhich exists by default in all databases)@multani This is the bug we talked about. Could you have a look please?