Simplify DefaultFunc to just Default

[VladRassokhin]

There's no need for functions and it can be inlined.
This change will help showing proper default values in IntelliJ-Terraform plugin.

[pdecat]

Indeed!

This used to be dynamic at some point: b89dbbd#diff-87d7af58ecf86062f1ac897d735c8c0dR216

But that was later changed.

Edit: can't recollect the actual use case back then, #193 was a long running PR that was reworked/rebased several times.

[pdecat]

LGTM!

[alexsomesan]

Change looks good at first glance.

Have you considered the implications of the default function now being evaluated a different time during runtime? Can that raise any issues? (I have to look into the differences myself).

[VladRassokhin]

Given how DefaultValue() works it's safe change.

Yes, execution time changes, but effect is still the same as function only relates on 'isComputed' which cannot differ over time because it's value, not pointer.

[pdecat]

AFAIR, the default value of some specific field was dynamic, but that was useless, so I removed it.
In the current implementation, all default values are static.
The only remaining "dynamic" part is if the isComputed parameter is true of false.

[VladRassokhin]

So, it's ok to merge? :)

[alexsomesan]

CI is green, I think we are good to merge.