Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reference link in K8s Deployment documentation #2602

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix reference link in K8s Deployment documentation #2602

merged 1 commit into from
Oct 15, 2024

Conversation

sheneska
Copy link
Contributor

Description

There is a broken link in the spec section of the kubernetes deployment resource documentation that has been updated.
Fixes Issue #2601.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@sheneska sheneska requested a review from a team as a code owner October 15, 2024 16:15
@sheneska sheneska added pr/no-changelog no-documentation This issue or pull request does not have documentation changes. labels Oct 15, 2024
SarahFrench
SarahFrench approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The replacement link makes sense to me!

@sheneska sheneska merged commit b4cf5b6 into main Oct 15, 2024
11 of 14 checks passed
@sheneska sheneska deleted the update-k8s-deployment-doc branch October 15, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahFrench SarahFrench SarahFrench approved these changes

Assignees
No one assigned
Labels
no-documentation This issue or pull request does not have documentation changes. pr/no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheneska @SarahFrench