Fix namespace requirement in template metadata #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arybolovlev
force-pushed
the
hotfix-namespace-requirement
branch
from
9e0790f
to
6ae2975
Compare
jrhouston
approved these changes
Jan 5, 2024
dduportal
referenced
this pull request
in jenkins-infra/azure
Jan 9, 2024
<Actions>
<action
id="bcd9b70d7c1eb1e07eb5ad8a958f18dc1bbd81461ee1a2604adeea46e3148a47">
<h3>Bump Terraform `kubernetes` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>"hashicorp/kubernetes" updated from "2.25.1" to
"2.25.2" in file ".terraform.lock.hcl"</p>
<details>
<summary>2.25.2</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v2.25.2
BUG
FIXES:

* `resource/kubernetes_cron_job_v1`: fix an issue when
the provider forces a resource recreation after upgrading to `2.25.0`
and `2.25.1` due to changes in the resource schema.
[[GH-2387](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2387)]
*
`resource/kubernetes_cron_job`: fix an issue when the provider forces a
resource recreation after upgrading to `2.25.0` and `2.25.1` due to
changes in the resource schema.
[[GH-2387](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2387)]
*
`resource/kubernetes_daemon_set_v1`: fix an issue when the provider
forces a resource recreation after upgrading to `2.25.0` and `2.25.1`
due to changes in the resource schema.
[[GH-2387](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2387)]
*
`resource/kubernetes_daemonset`: fix an issue when the provider forces a
resource recreation after upgrading to `2.25.0` and `2.25.1` due to
changes in the resource schema.
[[GH-2387](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2387)]
*
`resource/kubernetes_stateful_set_v1`: fix an issue when the provider
forces a resource recreation after upgrading to `2.25.0` and `2.25.1`
due to changes in the resource schema.
[[GH-2387](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2387)]
*
`resource/kubernetes_stateful_set`: fix an issue when the provider
forces a resource recreation after upgrading to `2.25.0` and `2.25.1`
due to changes in the resource schema.
[[GH-2387](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2387)]

NOTES:

*
Resources `kubernetes_cron_job_v1` and `kubernetes_cron_job` got a new
attribute `spec.job_template.metadata.namespace`. It is a stub attribute
that does not affect the namespace in which the Pod will be created. The
Pod will be created in the same namespace as the main resource. However,
modifying this field will force the resource recreation.
[[GH-2387](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2387)]
*
Resources `kubernetes_stateful_set_v1`, `kubernetes_stateful_set`,
`kubernetes_daemon_set_v1`, and `kubernetes_daemonset` got a new
attribute `spec.template.metadata.namespace`. It is a stub attribute
that does not affect the namespace in which the Pod will be created. The
Pod will be created in the same namespace as the main resource. However,
modifying this field will force the resource recreation.
[[GH-2387](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2387)]


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/996/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix an issue when the provider forces a resource recreation after upgrading to
2.25.0and2.25.1due to changes in the schema of the following resources:kubernetes_stateful_set_v1kubernetes_stateful_setkubernetes_daemon_set_v1kubernetes_daemonsetkubernetes_cron_job_v1kubernetes_cron_jobResources
kubernetes_stateful_set_v1,kubernetes_stateful_set,kubernetes_daemon_set_v1, andkubernetes_daemonsetgot a new attributespec.template.metadata.namespace. It is a stub attribute that does not affect the namespace in which the Pod will be created. The Pod will be created in the same namespace as the main resource. However, modifying this field will force the resource recreation.Resources
kubernetes_cron_job_v1andkubernetes_cron_jobgot a new attributespec.job_template.metadata.namespace. It is a stub attribute that does not affect the namespace in which the Pod will be created. The Pod will be created in the same namespace as the main resource. However, modifying this field will force the resource recreation.Acceptance tests
References
job_template's #2385Community Note