Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Golang linter #2341

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Add Golang linter #2341

merged 6 commits into from
Dec 11, 2023

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Nov 16, 2023 •
edited
Loading

Description

This PR has the following changes:

  • Add a new workflow to run golangci-lint on PRs that change *.go and go.mod files.
  • Add a new make target go-lint to run golangci-lint on a local machine.
  • Fix issues that linter has found.

How to enable golangci-lint for different editors: https://golangci-lint.run/usage/integrations/#editor-integration

Only some linters were enabled. This has been done on purpose. We could adopt and enable more as we ensure we need them.

Release Note

Release note for CHANGELOG:

NONE.

References

N/A.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@github-actions github-actions bot added size/L and removed size/M labels Nov 22, 2023
@github-actions github-actions bot added size/XL and removed size/L labels Dec 8, 2023
@arybolovlev arybolovlev marked this pull request as ready for review December 11, 2023 08:25
@arybolovlev arybolovlev requested a review from a team as a code owner December 11, 2023 08:25
alexsomesan
alexsomesan approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

@arybolovlev arybolovlev merged commit a56c3be into main Dec 11, 2023
38 checks passed
@arybolovlev arybolovlev deleted the add-linter branch December 11, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

@jrhouston jrhouston jrhouston approved these changes

Assignees
No one assigned
Labels
pr/no-changelog size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arybolovlev @alexsomesan @jrhouston