Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version for schedule #2186

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix version for schedule #2186

merged 1 commit into from
Jul 13, 2023

Conversation

sheneska
Copy link
Contributor

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@sheneska sheneska requested a review from a team as a code owner July 12, 2023 19:41
arybolovlev
arybolovlev approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! This is nice and smart! Thanks for fixing this! 🚀

@sheneska sheneska merged commit a39cc11 into main Jul 13, 2023
8 of 9 checks passed
@sheneska sheneska deleted the fix-kind-workflow branch July 13, 2023 14:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arybolovlev arybolovlev arybolovlev approved these changes

Assignees
No one assigned
Labels
pr/no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheneska @arybolovlev