Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pod metadata to replication controller spec template #193

Merged
merged 19 commits into from
Jan 11, 2019
Merged

Add pod metadata to replication controller spec template #193

merged 19 commits into from
Jan 11, 2019

Commits on Jan 11, 2019

  1. WIP (to rework): Fix replication controller metadata

    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    b637863 View commit details
    Browse the repository at this point in the history

  2. Revert acceptance tests timeout

    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    43b0220 View commit details
    Browse the repository at this point in the history

  3. Use dynamic default func to keep defaults when item is not computed i… 

    …n other use cases
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    b89dbbd View commit details
    Browse the repository at this point in the history

  4. Do not merge values from replication controller selector with labels … 

    …if labels are configured
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    9509aca View commit details
    Browse the repository at this point in the history

  5. Fix replication controller template flattener & expander functions to… 

    … let existing acceptance tests pass
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    b63a7ab View commit details
    Browse the repository at this point in the history

  6. Rename existing replication controller acceptance tests as deprecated… 

    … and introduce new tests using the non deprecated fields
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    40aa209 View commit details
    Browse the repository at this point in the history

  7. Prevent mixing deprecated spec fields with new ones to avoid complex … 

    …use-cases
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    aeae5f7 View commit details
    Browse the repository at this point in the history

  8. Do not try to merge deprecated replication controller spec fields wit… 

    …h new ones, mixed use-cases are now prevented
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    f94b7e4 View commit details
    Browse the repository at this point in the history

  9. Add labels and annotations to new replication controller template met… 

    …adata field
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    1925ae5 View commit details
    Browse the repository at this point in the history

  10. Refactor deprecated fields usage detection

    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    e94e5be View commit details
    Browse the repository at this point in the history

  11. Fix TestAccKubernetesReplicationController_deprecated_generatedName t… 

    …est case to use testAccKubernetesReplicationControllerConfig_deprecated_generatedName
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    bdbc47f View commit details
    Browse the repository at this point in the history

  12. TODO: Add conditional logic that returns an error if both the old and… 

    … new attributes are not defined to preserve the Required property of the spec fields.

cf. https://www.terraform.io/docs/extend/best-practices/deprecations.html#renaming-a-required-attribute
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    3e3c778 View commit details
    Browse the repository at this point in the history

  13. Put back d.GetOkExists() (but deprecated import test cases fail just … 

    …the same)
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    8a52669 View commit details
    Browse the repository at this point in the history

  14. Cleanup replication controller spec expander function

    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    feafef1 View commit details
    Browse the repository at this point in the history

  15. Disable state verification for import test cases with usage of deprec… 

    …ated template pod spec fields
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    d3b9f4a View commit details
    Browse the repository at this point in the history

  16. Format inline HCL in ACC tests with github.com/katbyte/terrafmt

    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    a0bb3a8 View commit details
    Browse the repository at this point in the history

  17. Return an error if new spec fields are used but no metadata is define… 

    …d to preserve the Required property of the metadata field
    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    7568f45 View commit details
    Browse the repository at this point in the history

  18. Update documentation of replication controller for hashicorp#193

    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    a273d9d View commit details
    Browse the repository at this point in the history

  19. Update changelog for hashicorp#193

    @pdecat
    pdecat committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    9532a33 View commit details
    Browse the repository at this point in the history