Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix #1922

Merged
merged 5 commits into from
Jan 4, 2023
Merged

Typo fix #1922

merged 5 commits into from
Jan 4, 2023

Conversation

shihai1991
Copy link
Contributor

@shihai1991 shihai1991 commented Dec 3, 2022 •
edited
Loading

No description provided.

@shihai1991 shihai1991 requested a review from a team as a code owner December 3, 2022 09:05
@hashicorp-cla
Copy link

hashicorp-cla commented Dec 3, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@arybolovlev
Copy link
Contributor

Hi @shihai1991,

Thank you for fixing this. Could you please make the same change in deployment_v1.html.markdown?

Thanks.

@shihai1991
Copy link
Contributor Author

Hi @shihai1991,

Thank you for fixing this. Could you please make the same change in deployment_v1.html.markdown?

Thanks.

Thanks Aleksandr for your review. I check all markdown file, and use readiness to replace liveness in readiness probes section.

arybolovlev
arybolovlev approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done, Hai!

Thank you for your contribution! The changes in documentation will be available with the upcoming release. Please, keep an eye on the release notes!

Happy New Year! 🎉

@arybolovlev arybolovlev merged commit 1615a36 into hashicorp:main Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arybolovlev arybolovlev arybolovlev approved these changes

Assignees
No one assigned
Labels
documentation pr/no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shihai1991 @hashicorp-cla @arybolovlev