Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/*: Treat non-string label values as invalid #135

Merged
merged 1 commit into from
Mar 5, 2018
Merged

resource/*: Treat non-string label values as invalid #135

merged 1 commit into from
Mar 5, 2018

Conversation

radeksimko
Copy link
Member

Fixes #108

This is merely a simple stop gap, the proper fix is upstream: hashicorp/terraform#17499

Test results

=== RUN   TestAccKubernetesNamespace_invalidLabelValueType
--- PASS: TestAccKubernetesNamespace_invalidLabelValueType (0.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	0.098s

@radeksimko radeksimko requested a review from a team March 5, 2018 12:47
@radeksimko radeksimko merged commit 2a4d31e into master Mar 5, 2018
@radeksimko radeksimko deleted the b-label-vals-invalid branch March 5, 2018 20:13
@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
bug crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when label is specified as a boolean
2 participants
@radeksimko @paddycarver