Allow the accepted types to be specified in the resource

[mvanholsteijn]

Hi there,
I would like to download the SAML metadata document and use it in my SAML provider in AWS. Unfortunately the http provider does not allow you to do that.

My suggestion is to use the "Accept" request header value to determine whether or not the data is accepted.

Terraform Version

Terraform v0.11.7
+ provider.auth0 v0.1.11
+ provider.http v1.0.1

Affected Resource(s)

• http

Terraform Configuration Files

data "http" "auth0-saml-metadata" {
  url = "https://${var.auth0_domain}/samlp/metadata/${auth0_client.oauth-cli.client_id}"
		request_headers {
    "Accept" = "application/xml"
  }
}

resource "aws_iam_saml_provider" "default" {
  name                   = "auth0-${replace(var.auth0_domain,".","-")}-provider"
  saml_metadata_document = "${data.http.auth0-saml-metadata.body}"
}

Expected Behavior

The SAML metadata document is downloaded and its body passed into the IAM SAML provider.

Actual Behavior

* data.http.auth0-saml-metadata: data.http.auth0-saml-metadata: Content-Type is not a text type. Got: application/xml; charset=utf-8

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

1. terraform apply

data "http" "auth0-saml-metadata" {
  url = "http://httpbin.org/xml"
}

References

• remote saml_metadata_document #13
• http provider too strict with application/json content type #1

[tmccombs]

@mvanholsteijn are you planning on opening a PR to address this?

[mvanholsteijn]

@tmccombs I did create a PR -> #16. I added the functionality in the style of the current code but unfortunately, the reviewer wanted to have a completed different implementation.

[seboudry]

Hi @aicarmic !

Any update about when this feature will be available?

[paultyng]

This should be resolved now in #50

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.