Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v1alpha1 diagnostic message / updated docs #895

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jun 23, 2022

Description

Prevents any future users to get issues when using helm provider by leading them to right version to use.

when running terraform plan with api_version set to v1alpha1 in exec block

│ Warning: v1alpha1 is not recommended, use v1beta1
│ 
│   with provider["registry.terraform.io/hashicorp/helm"],
│   on main.tf line 14, in provider "helm":
│   14:       api_version = "client.authentication.k8s.io/v1alpha1"
│ 
│ v1alpha1 authentication API was removed in Kubernetes 1.24, removal of alpha APIs is expected in minor version bumps of Kubernetes
│ 
│ (and one more similar warning elsewhere)

Release Note

Release note for CHANGELOG:

NONE

References

#893

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

helm/provider.go Outdated Show resolved Hide resolved
helm/provider.go Outdated Show resolved Hide resolved
BBBmau and others added 3 commits June 24, 2022 08:47
Co-authored-by: John Houston <jrhouston@users.noreply.github.com>
Co-authored-by: John Houston <jrhouston@users.noreply.github.com>
@BBBmau BBBmau requested a review from jrhouston June 28, 2022 01:08
@jrhouston jrhouston merged commit 7087473 into main Jun 29, 2022
@jrhouston jrhouston deleted the v1alpha1-diagnostic branch June 29, 2022 19:57
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants