Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pagination for Vault OpenAppSecrets preview API #1109

Merged
merged 13 commits into from
Oct 8, 2024
Merged

Support pagination for Vault OpenAppSecrets preview API #1109

merged 13 commits into from
Oct 8, 2024

Conversation

divyapola5
Copy link
Contributor

🛠️ Description

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • [*] Have you added an acceptance test for the functionality being added?
  • [*] Have you run the acceptance tests on this branch?

Output from acceptance testing:
Screenshot 2024-10-01 at 9 26 42 AM

$ make testacc TESTARGS='-run=TestAccXXX'

...

@divyapola5 divyapola5 requested a review from a team as a code owner October 1, 2024 14:33
@divyapola5 divyapola5 requested a review from a team as a code owner October 1, 2024 15:20
hghaf099
hghaf099 reviewed Oct 8, 2024
View reviewed changes
internal/clients/vault_secrets_preview.go Show resolved Hide resolved
internal/clients/vault_secrets_preview.go Outdated Show resolved Hide resolved
internal/clients/vault_secrets_preview.go Outdated Show resolved Hide resolved
hghaf099
hghaf099 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@hghaf099 hghaf099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think there is still room for improving test coverage. But, that should not be gating this PR.

@divyapola5 divyapola5 merged commit efee191 into main Oct 8, 2024
6 checks passed
@divyapola5 divyapola5 deleted the divyapola5/vault-31109 branch October 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigo-hcp rodrigo-hcp rodrigo-hcp left review comments

@jasonpilz jasonpilz jasonpilz approved these changes

@hghaf099 hghaf099 hghaf099 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@divyapola5 @jasonpilz @hghaf099 @rodrigo-hcp