Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMEK to Google Secret Manager #8976

Closed
wants to merge 2 commits into from

Conversation

SKAUL05
Copy link
Contributor

@SKAUL05 SKAUL05 commented Apr 22, 2021

Fixes: #8917

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

secret-manager: added support for setting a CMEK on `google_secret_manager_secret` 

@ghost ghost added size/l labels Apr 22, 2021
@ghost ghost requested review from c2thorn April 22, 2021 05:48
@SKAUL05
Copy link
Contributor Author

SKAUL05 commented Apr 29, 2021

@c2thorn Have you reviewed it yet?

@c2thorn
Copy link
Collaborator

c2thorn commented Apr 29, 2021

/gcbrun

@SKAUL05
Copy link
Contributor Author

SKAUL05 commented Apr 30, 2021

/gcbrun

@c2thorn I think build didn't run or did it?

@c2thorn
Copy link
Collaborator

c2thorn commented Apr 30, 2021

@c2thorn I think build didn't run or did it?

Silly mistake on my part, I thought we were in https://github.com/GoogleCloudPlatform/magic-modules 🤣

Heads up, Magic Modules is our upstream repository that generates code for this resource. Changes made here will get overridden. I've added the field and your test in GoogleCloudPlatform/magic-modules#4752 and it looks mostly the same with a few minor differences (ordering). But everything seems to work.

@@ -100,6 +100,18 @@ The `replicas` block supports:
(Required)
The canonical IDs of the location to replicate data. For example: "us-east1".

* `custom_managed_encryption` -
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ended up needing to be customer_managed_encryption

@c2thorn
Copy link
Collaborator

c2thorn commented Apr 30, 2021

The upstream PR will now get reviewed. If it's all the same to you, we can close this PR and let the upstream PR maintain any further changes if needed (I've added you as a co-author).

@SKAUL05
Copy link
Contributor Author

SKAUL05 commented Apr 30, 2021

The upstream PR will now get reviewed. If it's all the same to you, we can close this PR and let the upstream PR maintain any further changes if needed (I've added you as a co-author).

Works for me!

@ghost
Copy link

ghost commented May 31, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support CMEK for Secret Manager secrets
2 participants