Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path on GCS targets in google_storage_transfer_job #8931

Closed
wants to merge 2 commits into from
Closed

Add path on GCS targets in google_storage_transfer_job #8931

wants to merge 2 commits into from

Conversation

bambuchaAdm
Copy link
Contributor

@bambuchaAdm bambuchaAdm commented Apr 16, 2021 •
edited
Loading

Fix #8704

It is my first contribution and i am little concern about style in documentation. It was copied out form REST api docs, but could be little confusing on usage. What do you think ?

@ghost ghost added the size/xs label Apr 16, 2021
@ghost ghost requested review from ScottSuarez April 16, 2021 11:10
ScottSuarez
ScottSuarez requested changes Apr 16, 2021
View reviewed changes
google/resource_storage_transfer_job.go Outdated Show resolved Hide resolved
google/resource_storage_transfer_job.go Outdated Show resolved Hide resolved
google/resource_storage_transfer_job.go Show resolved Hide resolved
@bambuchaAdm bambuchaAdm force-pushed the google_storage_transfer_job_gcs_path branch from 03e7bc9 to 5fd5887 Compare April 30, 2021 14:21
@bambuchaAdm
Copy link
Contributor Author

Property marked as computed. Is this mark would prevent engine from detect difference if this variable would be not specified in resource ? I also made little amendment in first commit message to reference original issue.

@bambuchaAdm
Copy link
Contributor Author

@ScottSuarez Would you like to make again review on code after requested fixes ?

@ScottSuarez
Copy link
Collaborator

ah this has escaped me, let me take a looksee. sorry about that /gcbrun

@ScottSuarez
Copy link
Collaborator

gosh sorry about the delay ! let me upstream the change. looks good

@ScottSuarez ScottSuarez mentioned this pull request Aug 19, 2021
Merged
5 tasks
@ScottSuarez
Copy link
Collaborator

superseded by GoogleCloudPlatform/magic-modules#5117

This was referenced Sep 9, 2021
Merged
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ScottSuarez ScottSuarez Awaiting requested review from ScottSuarez

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_storage_transfer_job add support for path in gcp data sink
2 participants
@bambuchaAdm @ScottSuarez