Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation link #8030

Closed
wants to merge 1 commit into from
Closed

Fix documentation link #8030

wants to merge 1 commit into from

Conversation

joe-a-t
Copy link

@joe-a-t joe-a-t commented Dec 16, 2020

The existing link only mentioned SQL Server version but the new link is a superset that lists the supported versions for all types of SQL databases. Also updated the list of supported values.

The existing link only mentioned `SQL Server` version but the new link is a superset that lists the supported versions for all types of SQL databases. Also updated the list of supported values.
@ghost ghost added size/xs labels Dec 16, 2020
@ghost ghost requested a review from nat-henderson December 16, 2020 17:52
@joe-a-t
Copy link
Author

joe-a-t commented Dec 16, 2020

@ndmckinley I'm not sure what's going on with the test, it looks completely unrelated to my PR since I only touched 1 link which definitely exists

@nat-henderson
Copy link
Contributor

Awesome, thanks for the update - don't worry about the test, it's failing at master, frankly we don't know where the broken link is supposed to be either!

However, this is actually generated code. Would you mind making this same change in github.com/GoogleCloudPlatform/magic-modules? I think this one is in third_party/terraform/website there, but if not, you should find/replace the url in products/sql/api.yaml.

@joe-a-t
Copy link
Author

joe-a-t commented Dec 16, 2020

Changed via GoogleCloudPlatform/magic-modules#4327, thanks!

@joe-a-t joe-a-t closed this Dec 16, 2020
@joe-a-t joe-a-t deleted the patch-1 branch December 16, 2020 22:08
@ghost
Copy link

ghost commented Jan 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants