Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trust to ad domain 5731 #7056

Conversation

modular-magician
Copy link
Collaborator

Release Note Template for Downstream PRs (will be copied)

AD Domain - added new resource `google_active_directory_domain_trust` 

Derived from GoogleCloudPlatform/magic-modules#3798

* AD Domain resource added

* fmt issue fixed

* validation regex and input flag added

* Trust resouce attributes added to api.yaml

* ad domain trust resource added

* ad domain trust resource added

* post_create attribute added

* nested_query attribute added - work in progress

* work in progress - peer review

* encoder and decoder added - wip

* custom encoders and decoders added for update and delete resource

* comment removed

* comment added

* comment syntax corrected

* comments added as PR review comments

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xl label Aug 18, 2020
@modular-magician modular-magician merged commit 955f4b4 into hashicorp:master Aug 18, 2020
@ghost
Copy link

ghost commented Sep 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant