Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Missing Cloud Build Attributes #6942

Conversation

modular-magician
Copy link
Collaborator

Ref: #6531
Ref: #3576

Q for reviewer/maintainer (while in draft): want to ensure I am going in the right direction with what was done thus far. Should I be adding test? Overriding in terraform.yaml? Open to hearing anything and everything 🙂

Release Note Template for Downstream PRs (will be copied)

cloudbuild: added tags, source, queue_ttl, logs_bucket, substitutions, and secrets to `google_cloudbuild_trigger`

Derived from GoogleCloudPlatform/magic-modules#3627

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit d0fa2ac into hashicorp:master Aug 5, 2020
@ghost
Copy link

ghost commented Sep 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant