Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription with topic in different project #640

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Subscription with topic in different project #640

merged 1 commit into from
Oct 30, 2017

Commits on Oct 27, 2017

  1. Subscription with topic in different project 

    Right now we can't create subscription on a topic in a different gcp
project since it assume the project from the subscription. The provider
always create the full topic name string
projects/{project}/topics/{topic} with the received topic property.
Using a regexp we validate if the string is already in
the format projects/{project}/topics/{topic} and if it's the case
we don't wrap it again and take it directly. The original functionality
is maintained but it's possible to specify a different project for the
topic.
    Sebastien Robert committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    368cd32 View commit details
    Browse the repository at this point in the history