Fix ApigeeOrganization update response type. #20854
Merged
+216
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15947.
This PR fixes the
ApigeeOrganization
update response type according to the public documentation.The issue is related to the fact that after requesting the update to
ApigeeOrganization
here, the provider expects that the response will contain the Operation details to then wait for theOperation
to complete here. Unlike Organization create request, which returnsOperation
, the update response is an Organization instance according to the public docs, meaning that the ApigeeOperationWaitTime tries to process theOrganization
asOperation
.The Operation has a
name
key that is used to track its progress. However, theOrganization
also has aname
key, that contains the name of theOrganization
. That's why the users see a weirdapigee.googleapis.com/v1/<org-name>?alt=json
GET
request in a linked GitHub issue. In that case, theApigeeOperationWaitTime
interprets<org-name>
as the operation name.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#12413