Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ApigeeEnvironment update response type. #20745

Conversation

modular-magician
Copy link
Collaborator

This PR fixes the ApigeeEnvironment update response type according to the public documentation.

The issue is related to the fact that after requesting the update to ApigeeEnvironment here, the provider expects that the response will contain the Operation details to then wait for the Operation to complete here. Unlike Environment create request, which returns Operation, the update response has a type Environment according to the public docs, meaning that the ApigeeOperationWaitTime tries to process the Environment as Operation.

The Operation has a name key that is used to track its progress. However, the Environment also has a name key that contains the name of the Environment. That's why the users may see a weird apigee.googleapis.com/v1/<env-name>?alt=json GET requests that result in 404 Not Found while doing an update to their environments. In that case, the ApigeeOperationWaitTime interprets <env-name> as the operation name.

Here's a fix to a similar issue for the ApigeeOrganization: GoogleCloudPlatform/magic-modules#12413

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

apigee: fixed error 404 for `environment` update requests.

Derived from GoogleCloudPlatform/magic-modules#12415

[upstream:54c7ca8f9f45eab99bdce4dc574085828bfd3f3d]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner December 18, 2024 21:42
@modular-magician modular-magician merged commit 6e4c36c into hashicorp:main Dec 18, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant