Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute: added network_id to google_compute_network #20698

Conversation

modular-magician
Copy link
Collaborator

Add network_id to google_compute_network.

It's an integer, not a string, and follows the expected convention for naming.

This adds a note deprecating numeric_id (to be potentially removed at some later date), which will have the same value, but as a string.

Part of terraform-provider-google#20530

See also #12351 and #12339, in particular this comment, this comment, and this discussion

Let me know if you want me to break this up into two separate release notes.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `network_id` (integer) to `google_compute_network` resource and data source
compute: deprecated `numeric_id` (string) field in `google_compute_network` resource. Use the new `network_id` (integer)  field instead 

Derived from GoogleCloudPlatform/magic-modules#12504

)

[upstream:219edef6198ad089672bcea662015ea5a3e3594a]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner December 16, 2024 01:15
@modular-magician modular-magician merged commit a4bdf40 into hashicorp:main Dec 16, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant